Skip to content

Conversation

@waralexrom
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

- Add compile() method that builds graph from cube definitions
- Validate joins: target cube exists, primary keys for multiplied measures
- Build edges HashMap with "from-to" keys
- Build nodes HashMap (directed graph)
- Build undirected_nodes HashMap (bidirectional connectivity)
- Add 8 comprehensive unit tests
@github-actions github-actions bot added the rust Pull requests that update Rust code label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.98%. Comparing base (e72912c) to head (7fb8ba7).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10143   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files         457      457           
  Lines       91092    91092           
  Branches     3337     3337           
=======================================
  Hits        71041    71041           
  Misses      19573    19573           
  Partials      478      478           
Flag Coverage Δ
cube-backend 54.72% <ø> (ø)
cubesql 83.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@waralexrom waralexrom merged commit bdb4c20 into master Nov 17, 2025
157 of 160 checks passed
@waralexrom waralexrom deleted the tesseract-join-graph-mock branch November 17, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants